Repository navigation
fix(xtest): satisfy ruff on otdf-local's golden-key loader - #687
Merged
Merged
Conversation
Signed-off-by: Dave Mihalcik <dmihalcik@virtru.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
dmihalcik-virtru
changed the title
elizabethhealy
approved these changes
Oct 29, 2026
strantalis
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainfails thescriptcheckjob's "Lint and test otdf-local" step since #647 (run on 178baa1). ruff 0.17.0 reports:TRY004atotdf_local/utils/keys.py:233and:241: twoisinstancechecks in_read_extra_keysraiseValueError.I001attests/test_golden_keys.py:8: the first-party import group isn't separated frompytest.While these are assertions of values, since they are on data from JSON objects, ValueError is more correct.
Changes
ValueErrorfor those two checks and add# noqa: TRY004. The function's docstring promises aValueErrornaming the file for every problem withextra-keys.json, andPlatformService._preflightcatchesValueErrorto report it as a start error. Switching toTypeErrorto satisfy the rule would break that.ruff check --fixon the test's imports.Testing
Run locally in
otdf-local/:uv run ruff check .anduv run ruff format --check .: clean.uv run pyright: 0 errors.uv run pytest: 109 passed.The same commit is also on #624, which hit this failure after rebasing onto
main.