Skip to content

docs: fix more typos#3027

Merged
drgrice1 merged 1 commit into
openwebwork:developfrom
jeis4wpi:develop
Jun 24, 2026
Merged

docs: fix more typos#3027
drgrice1 merged 1 commit into
openwebwork:developfrom
jeis4wpi:develop

Conversation

@jeis4wpi

Copy link
Copy Markdown
Contributor

docs: fix more typos

Is this one okay as well ?

Signed-off-by: John E <jeis4wpi@outlook.com>
@somiaj

somiaj commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Thanks again.

@drgrice1 drgrice1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Just a tip for future pull requests. When making a pull request it should be done with a different branch than develop. You should execute git checkout -b pull-request-branch-name when the develop branch is checked out. That is where pull-request-branch-name is a short descriptive name for the branch and the changes it makes. For example, for this pull request you could use typo-fixes.

Also, rather than asking if the pull request is okay, just give a description of what is done for the pull request message. For this, something like docs: fix more typos would be sufficient. You don't need to also ask if the pull request is okay.

@drgrice1 drgrice1 merged commit 6b84364 into openwebwork:develop Jun 24, 2026
2 checks passed
@jeis4wpi

Copy link
Copy Markdown
Contributor Author

Thank you for the feedback. Apologies for the wrong branch.

Best of luck with 2.21 release.

@somiaj

somiaj commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@drgrice1 Are you going to make a PR for the release branch? I can if you aren't already doing that.

drgrice1 added a commit that referenced this pull request Jun 24, 2026
More typo fixes (#3027 for the release candidate)
@drgrice1

Copy link
Copy Markdown
Member

@somiaj: Thanks for reminding me. It is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants