Upgrade to libzim 9.8.1 + other dependencies#215
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.eslintrc.cjsto flat config (eslint.config.js), required by the ESLint 10 upgrade — same ruleset, no behavior changenpm run tsc, which was reporting ~270 errors, almost all from a single missingtsconfig.json"types"entry: TypeScript 6 no longer auto-includes@types/*packages, so Jest globals (describe/it/expect) were invisible. Added"types": ["jest", "node"], plus a few small fixes it then surfaced (missingtqdmtype declaration, a non-null assertion in a test, excludingdist/eslint.config.jsfrom the program)tsctype-check step to CI so this doesn't regress silently againWhy bumping
moduletoes2022is safetsconfig.json'smoduleonly affectstsctype-checking andts-jest's in-test transpilation — nothing it emits is shipped. The package'sdist/index.js/index.d.tsare hand-written files copied verbatim bynpm run prepare, and the native addon is built separately vianode-gyp. So this setting is invisible to consumers, whether their own project is CommonJS or ESM.Why not using Typescript 7
typescriptis stuck at version 6 because@typescript-eslint/parserdoes not (yet?) supports version 7.