[os-cloudflared] Correct UI token entry text field validation mask - #5598
Merged
Conversation
…e standardly present in Cloudflare tunnel tokens
Member
|
@insanityinside fyi |
Contributor
|
Will double check the validation logic, in case I've missed anything else. |
Contributor
|
I missed the = from the Base64 encoding validation for the token. Looks good to me, @csedm please bump the version in the Makefile to 1.2 before it gets merged. |
Contributor
Author
|
Done, thank you! |
Monviech
reviewed
Aug 4, 2026
Member
|
Merged, thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct UI token entry text field validation mask to include equal signs which are standardly present in Cloudflare tunnel tokens
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
If AI was used, please disclose:
Describe the problem
Valid cloudflared tunnel tokens from the dashboard cannot be entered under the current UI text field validation mask.
Describe the proposed solution
Add the equal sign to the hash as a valid character, allowing valid tokens to be entered. Update validation error message to include the equal sign.
Related issue
#5597
Additional notes
It's worth mentioning I'm not 100% positive this is the correct and complete fix since so it ought to be validated by someone who knows this project better than I do. It looks sufficiently correct to me based on examination of similar files on my own OPNsense system and successful testing of the fix.