Skip to content

[os-cloudflared] Correct UI token entry text field validation mask - #5598

Merged
Monviech merged 3 commits into
opnsense:masterfrom
csedm:issue-5597
Aug 5, 2026
Merged

[os-cloudflared] Correct UI token entry text field validation mask#5598
Monviech merged 3 commits into
opnsense:masterfrom
csedm:issue-5597

Conversation

@csedm

@csedm csedm commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Correct UI token entry text field validation mask to include equal signs which are standardly present in Cloudflare tunnel tokens

Important notices

Before you submit a pull request, we ask you kindly to acknowledge the following:

If AI was used, please disclose:

  • Model used: N/A
  • Extent of AI involvement: none

Describe the problem

Valid cloudflared tunnel tokens from the dashboard cannot be entered under the current UI text field validation mask.


Describe the proposed solution

Add the equal sign to the hash as a valid character, allowing valid tokens to be entered. Update validation error message to include the equal sign.


Related issue

#5597

Additional notes
It's worth mentioning I'm not 100% positive this is the correct and complete fix since so it ought to be validated by someone who knows this project better than I do. It looks sufficiently correct to me based on examination of similar files on my own OPNsense system and successful testing of the fix.

…e standardly present in Cloudflare tunnel tokens
@csedm csedm changed the title Correct UI text field validation mask to include equal signs which are standardly present in Cloudflare tunnel tokens [os-cloudflared] Correct UI token entry text field validation mask to include equal signs which are standardly present in Cloudflare tunnel tokens Aug 3, 2026
@csedm csedm changed the title [os-cloudflared] Correct UI token entry text field validation mask to include equal signs which are standardly present in Cloudflare tunnel tokens [os-cloudflared] Correct UI token entry text field validation mask Aug 3, 2026
@Monviech

Monviech commented Aug 4, 2026

Copy link
Copy Markdown
Member

@insanityinside fyi

@insanityinside

Copy link
Copy Markdown
Contributor

Will double check the validation logic, in case I've missed anything else.

@insanityinside

insanityinside commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

I missed the = from the Base64 encoding validation for the token. Looks good to me, @csedm please bump the version in the Makefile to 1.2 before it gets merged.

@csedm

csedm commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Done, thank you!

@Monviech Monviech self-assigned this Aug 4, 2026
@Monviech Monviech added the cleanup Low impact changes label Aug 4, 2026
Comment thread net/cloudflared/Makefile Outdated
@Monviech
Monviech merged commit 833b944 into opnsense:master Aug 5, 2026
@Monviech

Monviech commented Aug 5, 2026

Copy link
Copy Markdown
Member

Merged, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Low impact changes

Development

Successfully merging this pull request may close these issues.

3 participants