Repository navigation
fix: serialize native business retries and pace physical contention - #380
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Business retries receive a fresh task UUID. A second engine could therefore enter the same workflow instance/block while the predecessor callback was still physically running, bypassing task-ID-only exclusion.
Atomically reserve both canonical backend/task identity and backend/instance/block identity. Retain both through callback and foreign destructor completion; claim generations, worker identity changes and fresh business-retry UUIDs cannot overlap. Different instances, blocks and backends remain independent.
Physical contention previously caused 167 poll/release cycles in 200ms in the regression. Pace subsequent polls using the worker idle cadence, clamped to 1–30 seconds. Already delivered independent work stays admissible, graceful draining is unchanged, and the pending retry resumes after physical return.
Validation: