Skip to content

NO-ISSUE: Require osac pre-commit, unit, and integration checks - #191

Merged
eliorerz merged 1 commit into
osac-project:mainfrom
minmzzhang:require-osac-pr-ci-checks
Aug 19, 2026
Merged

NO-ISSUE: Require osac pre-commit, unit, and integration checks#191
eliorerz merged 1 commit into
osac-project:mainfrom
minmzzhang:require-osac-pr-ci-checks

Conversation

@minmzzhang

@minmzzhang minmzzhang commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add existing osac GitHub Actions jobs (pre-commit, unit tests, integration tests) to repo_osac required_status_checks so failures block merge.
  • No new gate jobs. Job-level if: skips already report success, so docs-only PRs stay mergeable.

Test plan

  • tofu plan shows only repo_osac required-check additions
  • After apply, a code PR that fails unit/integration/pre-commit cannot merge
  • Docs-only PR still mergeable (skipped jobs count as success)

Summary by CodeRabbit

  • Chores
    • Expanded required status checks for repository changes.
    • Added validation for pre-commit checks, unit tests, and integration tests across key service and installer components.

Unit, integration, and pre-commit jobs already run on PRs but only e2e
gates and check-labels block merge.
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b790a246-6fc9-4c4c-ac55-c237a1a0d6d5

📥 Commits

Reviewing files that changed from the base of the PR and between 73a688c and f7bfde1.

📒 Files selected for processing (1)
  • repositories.tf

Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review.


Walkthrough

The repo_osac repository ruleset now requires pre-commit, unit-test, and integration-test status checks for the specified service and operator jobs.

Changes

OSAC repository protection

Layer / File(s) Summary
Add required CI status checks
repositories.tf
The repo_osac ruleset now requires pre-commit, four unit-test jobs, and four integration-test jobs for fulfillment-service, osac-operator, osac-aap, and osac-installer.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🔵 Low · up to f7bfd

This PR adds existing osac CI checks as merge requirements. It is mergeable with owner awareness, but the exact check names and skipped-job behavior should be confirmed before applying the rule to avoid unexpectedly blocking valid merges or weakening enforcement.

Suggested reviewers: larsks, eliorerz, omer-vishlitzky

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the required pre-commit, unit, and integration checks added for osac.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed The PR adds only status-check names and integration_id 15368 in repositories.tf; the added-line scan found no secret-shaped literals, credentials, URLs, keys, or token assignments.
No-Weak-Crypto ✅ Passed The PR changes only repositories.tf by adding GitHub status-check strings and comments; no MD5, SHA1, DES, RC4, Blowfish, ECB, or crypto implementation is added.
No-Injection-Vectors ✅ Passed The PR adds only static Terraform status-check strings. No SQL, shell, eval/exec, pickle, unsafe YAML, os.system, or dangerouslySetInnerHTML pattern is introduced.
Container-Privileges ✅ Passed The commit changes only required_status_checks in repositories.tf; the diff adds no container or Kubernetes privilege settings, and the tracked-file search found none.
No-Sensitive-Data-In-Logs ✅ Passed The diff changes only repo_osac required status-check declarations. It adds no logging or sensitive-data output, and the changed file has no logging or secret-related patterns.
Ai-Attribution ✅ Passed The PR description and changed commit do not mention an AI tool; the commit has no Co-Authored-By trailer. Existing Assisted-by trailers are outside this PR.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@eliorerz
eliorerz merged commit f4915a4 into osac-project:main Aug 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants