Repository navigation
Keep the callable passed to create_task alive while the task runs - #59
Merged
Merged
Conversation
create_task(callable) invoked a temporary lambda and returned its task, but the lambda was destroyed at the end of the caller's full-expression. A coroutine lambda reads its captures through the closure, so any capture used after the first suspension was dangling. This is the pattern the guide and examples use; under ASan TimerStreamTest.BasicNext reported stack-use-after-scope. Move the callable into a wrapper coroutine's frame, which awaits the task it returns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_task(callable)invoked a temporary lambda and returned its task, but the lambda was destroyed at the end of the caller's full-expression. A coroutine lambda reads its captures through the closure, so any capture used after the first suspension was dangling:This is the pattern the guide and the examples use. Under ASan,
TimerStreamTest.BasicNextreported stack-use-after-scope (mentioned in #56).The callable is now moved into a wrapper coroutine's frame, which awaits the task it returns, so the captures live as long as the task.
SleepTest.CreateTaskKeepsTheLambdaAlivechecks that the lambda's captures are still alive aftercreate_taskreturns. It fails on main, where the capture has already been destroyed. With this change, the full suite passes in Debug, andtest_sleep/test_timer_streamare clean under ASan.