Repository navigation
ci: add zizmor workflow audit - #41
Open
oc-tmueller wants to merge 3 commits into
Open
oc-tmueller wants to merge 3 commits into
oc-tmueller wants to merge 3 commits into
Conversation
Runs zizmor over this repository's workflows and Dependabot config on every pull request, on pushes to the default branch and weekly, through owncloud/reusable-workflows' zizmor.yml. Any finding fails the check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
- template-injection: workflow_dispatch inputs (from_version, to_version), reusable-workflow inputs (ssh host/user/key, oCIS URL, APK version and artifact name) and job outputs were expanded straight into run: scripts, so a crafted value became shell code. They are now passed through env: and quoted where used as paths. - secrets-inherit: sign_latest and sign_master passed every repository secret to sign-apk.yml; they now pass only the three it declares (TEST_KS_B64, TEST_KS_ALIAS, TEST_KS_KEY). - self-repository: local reusable workflows and the ansible-setup action are called as $/... instead of ./... . - artipacked: checkouts do not persist credentials. No job runs a git operation after checkout other than reading history. - dependabot-cooldown: gradle updates wait 7 days too, as github-actions already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
Only the zizmor caller's concurrency comment changes: GitHub keeps one queued run per group, so for non-pull-request events a newer run still replaces a queued one; the comment now says so instead of claiming only pull request runs are superseded. sign-apk's cp and ansible-setup's ssh-keyscan now quote the values that came from inputs, as the previous commit message already claimed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a zizmor audit of this repository's GitHub Actions workflows and Dependabot config, through the reusable
owncloud/reusable-workflows/.github/workflows/zizmor.yml(owncloud/reusable-workflows#104). It's part of an org-wide rollout. Once the repo PRs have landed,Zizmor / Zizmorbecomes a required check through owncloud/admin.mainand weekly, because online audits such as known-vulnerable actions can start failing without a code change.contents: readonly, so it also works on fork PRs.owncloud/*references may stay on@main. Everything else must be SHA-pinned.Existing findings fixed (separate commits)
run:scripts, so a crafted value became shell code. These are now passed throughenv:and quoted where used as paths:workflow_dispatchfrom_version/to_versionsign_latest/sign_masterpassed every repository secret tosign-apk.yml. They now pass only the three it declares (TEST_KS_B64,TEST_KS_ALIAS,TEST_KS_KEY).ansible-setupaction are called as$/...instead of./.... This is GitHub's self-repository syntax, which files written to the workspace at runtime cannot redirect.update.yml,ocisbackend.yml,sign-apk.ymlandcleanup.ymlonly run on schedule or dispatch. A manualUpdate Testdispatch after merge is the real check.ocisbackend.ymlwrites theocis_urldispatch input into$GITHUB_ENVunvalidated. Only users with write access can dispatch it.zizmor 1.31.1 reports no findings on this branch.
🤖 Generated with Claude Code