Skip to content

fix: recalculate grid span count after rotation#4894

Open
himu-gupta wants to merge 2 commits into
owncloud:masterfrom
himu-gupta:fix/grid-mode-orientation-4884
Open

fix: recalculate grid span count after rotation#4894
himu-gupta wants to merge 2 commits into
owncloud:masterfrom
himu-gupta:fix/grid-mode-orientation-4884

Conversation

@himu-gupta

Copy link
Copy Markdown

Summary

  • Recalculate the file-list grid span count after configuration changes.
  • Keep the fragment's selected view type in sync when toggling between list and grid.
  • Invalidate staggered-grid span assignments and request a relayout after the mode/orientation update.
  • Add an unreleased changelog entry.

Fixes #4884

Verification

  • JAVA_HOME="/Applications/Android Studio.app/Contents/jbr/Contents/Home" ANDROID_HOME="/Users/himu/Library/Android/sdk" ./gradlew --no-daemon --console=plain :owncloudApp:compileOriginalDebugKotlin
  • git diff --check

@CLAassistant

CLAassistant commented Jun 18, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@jesmrec jesmrec changed the title Fix grid span count after orientation change fix: fix grid span count after orientation change Jun 18, 2026
@joragua

joragua commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Hi @himu-gupta! Thanks for opening this PR! 🙌🏻

Some improvements here before the CR:

  1. Do not to forget to use Conventional commits for the message
  2. Commits must be GPG/PGP signed, and it'd be great if each commit include a Signed-off-by line
  3. I'd separate the calens into a different commit with the message: chore: add calens file

Let us know if you have any doubts and we will help you! I will start with the code review when all changes are done 🍻

@himu-gupta himu-gupta force-pushed the fix/grid-mode-orientation-4884 branch from 4a35526 to bc59543 Compare June 18, 2026 21:01
@himu-gupta himu-gupta changed the title fix: fix grid span count after orientation change fix: recalculate grid span count after rotation Jun 18, 2026
Signed-off-by: Himanshu Gupta <himu.gupta23@gmail.com>
Signed-off-by: Himanshu Gupta <himu.gupta23@gmail.com>
@himu-gupta himu-gupta force-pushed the fix/grid-mode-orientation-4884 branch from bc59543 to c889d0b Compare June 19, 2026 10:01
@himu-gupta

Copy link
Copy Markdown
Author

Hi @himu-gupta! Thanks for opening this PR! 🙌🏻

Some improvements here before the CR:

  1. Do not to forget to use Conventional commits for the message
  2. Commits must be GPG/PGP signed, and it'd be great if each commit include a Signed-off-by line
  3. I'd separate the calens into a different commit with the message: chore: add calens file

Let us know if you have any doubts and we will help you! I will start with the code review when all changes are done 🍻

Thanks @joragua, I have done the requested changes.

@jesmrec

jesmrec commented Jun 19, 2026

Copy link
Copy Markdown
Member

Thanks for your contribution @himu-gupta!! Let me tell you how the process is. Basically, there are two phases after the PR is correct (signed commits, separated changelog, conventional commits correct...):

  1. Code review: team will review the code you pushed and make suggestions for improvement. Usually, @joragua takes care of it.

  2. QA: Once code review is approved, the feature/fix will be tested to detect defects or unexpected behaviors. I will take care of that.

For sure, all CI checks must be green as well, otherwise merging will be blocked.

Code review will start soon, keep tuned!!

@himu-gupta

Copy link
Copy Markdown
Author

Thanks for your contribution @himu-gupta!! Let me tell you how the process is. Basically, there are two phases after the PR is correct (signed commits, separated changelog, conventional commits correct...):

  1. Code review: team will review the code you pushed and make suggestions for improvement. Usually, @joragua takes care of it.
  2. QA: Once code review is approved, the feature/fix will be tested to detect defects or unexpected behaviors. I will take care of that.

For sure, all CI checks must be green as well, otherwise merging will be blocked.

Code review will start soon, keep tuned!!

Thanks for the insight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Bad grid mode after changing orientation

4 participants