Skip to content

fix: adapt action mode bar to landscape insets#4895

Draft
himu-gupta wants to merge 2 commits into
owncloud:masterfrom
himu-gupta:fix/multiselect-topbar-edge-to-edge
Draft

fix: adapt action mode bar to landscape insets#4895
himu-gupta wants to merge 2 commits into
owncloud:masterfrom
himu-gupta:fix/multiselect-topbar-edge-to-edge

Conversation

@himu-gupta

@himu-gupta himu-gupta commented Jun 18, 2026

Copy link
Copy Markdown

Summary

  • Make the contextual multi-selection action bar consume landscape system bar and display cutout insets horizontally.
  • Keep the action icons visible by avoiding top inset padding on the AppCompat action mode content.
  • Add an unreleased changelog entry.

Fixes #4892

Verification

  • JAVA_HOME="/Applications/Android Studio.app/Contents/jbr/Contents/Home" ANDROID_HOME="/Users/himu/Library/Android/sdk" ./gradlew --no-daemon --console=plain :owncloudApp:compileOriginalDebugKotlin
  • JAVA_HOME="/Applications/Android Studio.app/Contents/jbr/Contents/Home" ANDROID_HOME="/Users/himu/Library/Android/sdk" ./gradlew --no-daemon --console=plain :owncloudApp:assembleOriginalDebug
  • git diff --check

@CLAassistant

CLAassistant commented Jun 18, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@jesmrec jesmrec changed the title Fix action mode top bar edge-to-edge in landscape fix: fix action mode top bar edge-to-edge in landscape Jun 18, 2026
@joragua

joragua commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Hi @himu-gupta! Thanks for opening this PR! 🍻

I've checked your code and it does not seem to work as expected because all the icons in the action bar are hidden, and the system bar does not span the full width of the screen. Is the PR still in progress? 🤔 If not, I think this is not a valid solution. Let us know if you have any doubts and we will be happy to help you!

NOTE: Do not forget to use conventional commits for the message. Commits must be GPG/PGP signed, and it'd be great if each commit include a Signed-off-by line. Also, I'd separate the calens into a different commit with the message: chore: add calens file

@himu-gupta himu-gupta force-pushed the fix/multiselect-topbar-edge-to-edge branch from ae96c3a to c33f0c0 Compare June 18, 2026 21:08
@himu-gupta himu-gupta changed the title fix: fix action mode top bar edge-to-edge in landscape fix: adapt action mode bar to landscape insets Jun 18, 2026
@himu-gupta himu-gupta marked this pull request as draft June 18, 2026 21:45
Signed-off-by: Himanshu Gupta <himu.gupta23@gmail.com>
Signed-off-by: Himanshu Gupta <himu.gupta23@gmail.com>
@himu-gupta himu-gupta force-pushed the fix/multiselect-topbar-edge-to-edge branch from c33f0c0 to 3f7c81e Compare June 19, 2026 01:31
@joragua

joragua commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Just two details before the CR @himu-gupta! 😄

Would it be possible to adjust the content of the action bar in order to prevent overlap between navigation buttons and the buttons from the bar. Also, would it be possible to extend the black system bar across the entire width of the device screen? 🤔 Thanks!

action_bar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Multi-selection top bar not adapted to edge-to-edge in landscape

3 participants