Repository navigation
ci: add zizmor workflow audit - #5036
Merged
Merged
Conversation
Runs zizmor over this repository's workflows and Dependabot config on every pull request, on pushes to the default branch and weekly, through owncloud/reusable-workflows' zizmor.yml. Any finding fails the check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
- template-injection: build-apk passes the build_variant input to its scripts through env: instead of expanding it into the script text. - github-app: the SBOM App token requests only contents and pull-requests write, which peter-evans/create-pull-request needs to push the signed branch and open the PR, instead of inheriting every permission of the installation. - artipacked: checkouts do not persist credentials. No job runs an authenticated git operation after checkout; the SBOM PR is pushed by create-pull-request with the App token. - dependabot-cooldown: gradle updates wait 7 days, as github-actions already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
The SBOM branch and PR are pushed and opened with the App token, and the remaining git calls are anonymous reads of this public repository, so the GITHUB_TOKEN no longer needs write access. The job runs third-party Gradle plugins, which could otherwise use it to push. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
jesmrec
approved these changes
Oct 27, 2026
joragua
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a zizmor audit of this repository's GitHub Actions workflows and Dependabot config, through the reusable
owncloud/reusable-workflows/.github/workflows/zizmor.yml(owncloud/reusable-workflows#104). It's part of an org-wide rollout. Once the repo PRs have landed,Zizmor / Zizmorbecomes a required check through owncloud/admin.masterand weekly, because online audits such as known-vulnerable actions can start failing without a code change.contents: readonly, so it also works on fork PRs.owncloud/*references may stay on@main. Everything else must be SHA-pinned.Existing findings fixed (separate commits)
build-apkpasses thebuild_variantinput to its scripts throughenv:instead of expanding it into the script text.contents: write+pull-requests: write, whichpeter-evans/create-pull-request(withsign-commits) needs. It no longer inherits every permission of the installation. This flow already pushes the branch and opens the PR with that token today, so the installation should grant both. The token step only runs when the SBOM changes, though, so this PR's CI doesn't exercise it.GITHUB_TOKENdrops fromcontents: writetocontents: read. Everything that writes uses the App token, and the job runs third-party Gradle plugins.Noticed but not changed: on a
workflow_dispatchrun of the SBOM workflow from a branch other thanmaster, the compare step'sorigin/master:sbom.jsonfallback can't resolve in the shallow checkout.zizmor 1.31.1 reports no findings on this branch.
🤖 Generated with Claude Code