Skip to content

ci: add zizmor workflow audit - #68

Merged
phil-davis merged 3 commits into
masterfrom
ci/zizmor
Oct 27, 2026
Merged

phil-davis merged 3 commits into
masterfrom
ci/zizmor

Conversation

@oc-tmueller

Copy link
Copy Markdown
Contributor

Adds a zizmor audit of this repository's GitHub Actions workflows and Dependabot config, through the reusable owncloud/reusable-workflows/.github/workflows/zizmor.yml (owncloud/reusable-workflows#104). It's part of an org-wide rollout. Once the repo PRs have landed, Zizmor / Zizmor becomes a required check through owncloud/admin.

  • Behaviour: any finding, at any severity, fails the check, with an annotation on the offending line. The check runs on every PR, on pushes to master and weekly, because online audits such as known-vulnerable actions can start failing without a code change.
  • Permissions: contents: read only, so it also works on fork PRs.
  • Config: owncloud/* references may stay on @main. Everything else must be SHA-pinned.

Existing findings fixed (separate commits)

  • dependabot-cooldown: npm updates wait 7 days.
  • excessive-permissions: ci.yml ran with the repository default, which is read/write. It now declares contents: read; its only job checks out, installs and runs the tests.
  • artipacked: the ci.yml checkout does not persist credentials.
  • cache-poisoning: suppressed inline. setup-node's npm cache is also used by tag builds, but this workflow publishes nothing. If a publish step is ever added, drop the cache for tags.

zizmor 1.31.1 reports no findings on this branch.

🤖 Generated with Claude Code

oc-tmueller and others added 3 commits October 26, 2026 14:33
Runs zizmor over this repository's workflows and Dependabot config on
every pull request, on pushes to the default branch and weekly, through
owncloud/reusable-workflows' zizmor.yml. Any finding fails the check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
- dependabot-cooldown: npm updates wait 7 days, as github-actions
  already does elsewhere in the org.
- excessive-permissions: ci.yml ran with the repository default, which
  is read/write; it now declares contents: read. Its single job only
  checks out, installs and runs the tests.
- artipacked: the ci.yml checkout does not persist credentials.
- cache-poisoning: suppressed inline. setup-node's npm cache is also
  used by tag builds, but this workflow publishes nothing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
GitHub keeps one pending run per concurrency group whatever
cancel-in-progress says, so a queued push run can still be replaced by a
newer one; only the weekly run is fully protected by the per-event
group. Same wording as owncloud/reusable-workflows#105.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
@oc-tmueller
oc-tmueller requested a review from a team as a code owner October 26, 2026 13:49
@phil-davis
phil-davis merged commit fefdef8 into master Oct 27, 2026
4 checks passed
@phil-davis
phil-davis deleted the ci/zizmor branch October 27, 2026 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants