Repository navigation
ci: add zizmor workflow audit - #162
Open
oc-tmueller wants to merge 3 commits into
Open
oc-tmueller wants to merge 3 commits into
oc-tmueller wants to merge 3 commits into
Conversation
Runs zizmor over this repository's workflows and Dependabot config on every pull request, on pushes to the default branch and weekly, through owncloud/reusable-workflows' zizmor.yml. Any finding fails the check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
- excessive-permissions: pages: write and id-token: write were granted workflow-wide, so the build job, which runs on every pull request, got them too. They now sit on the deploy job only, which runs on main and is the only job that publishes. - artipacked: checkouts do not persist credentials. No job runs a git operation after checkout. - dependabot-cooldown: npm updates wait 7 days too, as github-actions already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
Only the zizmor caller's concurrency comment changes: GitHub keeps one queued run per group, so for non-pull-request events a newer run still replaces a queued one; the comment now says so instead of claiming only pull request runs are superseded. The deploy job keeps contents: read alongside pages/id-token write, the token it had before, since a narrower one would only surface after merge. Correction to the previous commit message: config-docs-in-sync does run git ls-remote and git clone after checkout, but only against public repositories, which need no credentials. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
Contributor
|
CI failure is unrelated to these changes. There's a missing branch and version mismatch on master branch… @oc-tmueller should core include the 11.0 branch or should the version be updated here in content? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a zizmor audit of this repository's GitHub Actions workflows and Dependabot config, through the reusable
owncloud/reusable-workflows/.github/workflows/zizmor.yml(owncloud/reusable-workflows#104). It's part of an org-wide rollout. Once the repo PRs have landed,Zizmor / Zizmorbecomes a required check through owncloud/admin.mainand weekly, because online audits such as known-vulnerable actions can start failing without a code change.contents: readonly, so it also works on fork PRs.owncloud/*references may stay on@main. Everything else must be SHA-pinned.Existing findings fixed (separate commits)
pages: writeandid-token: writewere granted workflow-wide, so thebuildjob, which runs on every PR, had them too. They now sit only on thedeployjob (main only), which keeps thecontents: readit had before. The deploy job only runs onmain, so this PR's CI cannot exercise it. The first push tomainwill.config-docs-in-syncrunsgit ls-remote/git cloneonly against public repositories.zizmor 1.31.1 reports no findings on this branch.
🤖 Generated with Claude Code