Skip to content

ci: add zizmor workflow audit - #2

Merged
LukasHirt merged 3 commits into
owncloud:mainfrom
oc-tmueller:ci/zizmor
Oct 26, 2026
Merged

LukasHirt merged 3 commits into
owncloud:mainfrom
oc-tmueller:ci/zizmor

Conversation

@oc-tmueller

Copy link
Copy Markdown
Contributor

Adds a zizmor audit of this repository's GitHub Actions workflows and Dependabot config, through the reusable owncloud/reusable-workflows/.github/workflows/zizmor.yml (owncloud/reusable-workflows#104). It's part of an org-wide rollout. Once the repo PRs have landed, Zizmor / Zizmor becomes a required check through owncloud/admin.

  • Behaviour: any finding, at any severity, fails the check, with an annotation on the offending line. It runs on every PR, on pushes to main and weekly, because online audits such as known-vulnerable actions can start failing without a code change.
  • Permissions: contents: read only, so it also works on fork PRs.
  • Config: owncloud/* references may stay on @main. Everything else must be SHA-pinned.

Existing findings fixed (separate commits)

  • unpinned-uses: the Pages deploy actions are pinned to the commit their floating major tag points at today (checkout v4.4.0, configure-pages v5.0.0, upload-pages-artifact v3.0.1, deploy-pages v5.0.1). I checked that each SHA equals the current @vN target, so nothing changes except the pin.
    • This also unbreaks the deploy. The org Actions policy requires SHA pinning, and the last Deploy to GitHub Pages run (2026-07-13) ended in startup_failure.
  • artipacked: the checkout does not persist credentials.
  • The new workflow file carries the SPDX header that the REUSE setup requires.
  • Note: the repo has no Dependabot config, so these pins will not be bumped automatically.

zizmor 1.31.1 reports no findings on this branch.

🤖 Generated with Claude Code

oc-tmueller and others added 3 commits October 26, 2026 14:31
Runs zizmor over this repository's workflows and Dependabot config on
every pull request, on pushes to the default branch and weekly, through
owncloud/reusable-workflows' zizmor.yml. Any finding fails the check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
- unpinned-uses: the Pages deploy actions are pinned to the commit their
  floating major tag points at today (checkout v4.4.0, configure-pages
  v5.0.0, upload-pages-artifact v3.0.1, deploy-pages v5.0.1), so nothing
  changes but the pin. The org Actions policy requires SHA pinning, so
  the floating refs could not run there.
- artipacked: the checkout does not persist credentials; the job
  publishes through actions/deploy-pages, not git.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
Only the zizmor caller's concurrency comment changes: GitHub keeps one queued
run per group, so for non-pull-request events a newer run still replaces a
queued one; the comment now says so instead of claiming only pull request
runs are superseded.

The new workflow file carries the repository's SPDX header, which its
REUSE setup requires.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
@oc-tmueller
oc-tmueller requested a review from a team as a code owner October 26, 2026 13:49
@LukasHirt
LukasHirt merged commit 551799a into owncloud:main Oct 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants