Repository navigation
ci: add zizmor workflow audit - #328
Merged
Merged
Conversation
Runs zizmor over this repository's workflows and Dependabot config on every pull request, on pushes to the default branch and weekly, through owncloud/reusable-workflows' zizmor.yml. Any finding fails the check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
- dependabot-cooldown: composer updates wait 7 days, as github-actions already does elsewhere in the org. - excessive-permissions: ci.yml ran with the repository default, which is read/write. It now defaults to contents: read; only the docs job gets contents: write, for peaceiris/actions-gh-pages pushing the docs and docs-hugo branches. COMPOSER_TOKEN only needs read. - artipacked: checkouts do not persist credentials. The gh-pages pushes authenticate through the action's github_token input, not the checkout's credentials. - ref-version-mismatch: setup-php's tag is 2.40.0, without the v. - cache-poisoning: setup-go (cache: false) and setup-node (package-manager-cache: false) in build-ocis do not cache. The actions/cache steps for composer and the ocis binaries are suppressed inline: they only feed the tests, and the docs job publishes from source without them. - adhoc-packages: suppressed inline, pnpm is version-pinned (9.15.9). - ci.yml now ends with a newline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
GitHub keeps one pending run per concurrency group whatever cancel-in-progress says, so a queued push run can still be replaced by a newer one; only the weekly run is fully protected by the per-event group. Same wording as owncloud/reusable-workflows#105. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
LukasHirt
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a zizmor audit of this repository's GitHub Actions workflows and Dependabot config, through the reusable
owncloud/reusable-workflows/.github/workflows/zizmor.yml(owncloud/reusable-workflows#104). It's part of an org-wide rollout. Once the repo PRs have landed,Zizmor / Zizmorbecomes a required check through owncloud/admin.mainand weekly, because online audits such as known-vulnerable actions can start failing without a code change.contents: readonly, so it also works on fork PRs.owncloud/*references may stay on@main. Everything else must be SHA-pinned.Existing findings fixed (separate commits)
ci.ymlran with the repository default, which is read/write. It now defaults tocontents: read.docsjob getscontents: write, forpeaceiris/actions-gh-pagespushing thedocsanddocs-hugobranches.COMPOSER_TOKEN(theGITHUB_TOKEN) only needs read.SONAR_TOKEN. The build-ociscurl/git clonecalls are unauthenticated.github_tokeninput.2.40.0, without av.cache: false) and setup-node (package-manager-cache: false) in build-ocis no longer cache.actions/cachesteps for composer and the ocis binaries are suppressed inline: they only feed the tests, and the docs job publishes from source without them. zizmor's auto-fix would have setlookup-only: true, which never restores, so on a cache hitbuild-ociswould skip the build and upload no binaries. It was rejected.9.15.9).Not exercised by this PR's CI: the gh-pages publish steps, which only run on pushes to
mainand tags.zizmor 1.31.1 reports no findings on this branch.
🤖 Generated with Claude Code