Repository navigation
ci: add zizmor workflow audit - #72
Merged
Merged
Conversation
Runs zizmor over this repository's workflows and Dependabot config on every pull request, on pushes to the default branch and weekly, through owncloud/reusable-workflows' zizmor.yml. Any finding fails the check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
- excessive-permissions: CI declares contents: read. The repository default is already read-only, so nothing changes at runtime; the workflow no longer depends on that setting. - artipacked: checkouts do not persist credentials. The only git use after checkout is commitlint reading local history. - adhoc-packages: the unpinned commitlint install is suppressed inline. It is a lint-only tool for PR commit messages and runs with no secrets and a read-only token; the repository root has no lockfile to install it from. - dependabot-cooldown: npm and gomod updates wait 7 days, as github-actions already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
The unpinned commitlint install does not follow the root package.json: CI resolves the latest release (21.x today) while package.json and the husky hook use ^19.5.0, and npm also resolves the root devDependencies without a lockfile. Pinning would change which rules CI enforces, so the install stays as it is; the suppression now says it is a pre-existing gap left to the maintainers instead of claiming it is harmless. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
LukasHirt
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a zizmor audit of this repository's GitHub Actions workflows and Dependabot config, through the reusable
owncloud/reusable-workflows/.github/workflows/zizmor.yml(owncloud/reusable-workflows#104). It's part of an org-wide rollout. Once the repo PRs have landed,Zizmor / Zizmorbecomes a required check through owncloud/admin.mainand weekly, because online audits such as known-vulnerable actions can start failing without a code change.contents: readonly, so it also works on fork PRs.owncloud/*references may stay on@main. Everything else must be SHA-pinned.Existing findings fixed (separate commits)
contents: read. The repository default is already read-only, so nothing changes at runtime, but the workflow no longer depends on that setting.npm install --no-save @commitlint/cli @commitlint/config-conventional.For the maintainers: CI resolves the latest commitlint, 21.x today, while the root
package.jsonand the husky hook use^19.5.0. npm also resolves the root devDependencies (husky) without a lockfile. Pinning the install to thepackage.jsonrange, or committing a root lockfile and using a frozen install, would close the gap and let the suppression go. I left it as is because it would change which rules CI enforces. The rootpackage.jsonalso has no Dependabot entry; only/frontenddoes.zizmor 1.31.1 reports no findings on this branch.
🤖 Generated with Claude Code