Repository navigation
Add new been active messages for v14 - #2044
Conversation
leftwo
changed the title
17c3970 to
6972b4f
Compare
|
I'm messing around with the stacked PR stuff, let me know if the diff looks weird. |
Add the new messages for protocol V14 to the end of Message struct. The tags of every existing message are unchanged. Nothing sends the new messages yet. The current protocol version stays at 13.
e86086e to
2c23388
Compare
| // | ||
| // These belong with the negotiation messages above, but are placed here | ||
| // so that the wire tags of every V13 message are unchanged. They must | ||
| // only be sent on a connection that negotiated V14 or later. |
There was a problem hiding this comment.
let's add a space here, I think it will help readability
There was a problem hiding this comment.
Done.
But, overall, I'm not happy how we have these grouped into nice sections, but then when we changed the
protocol, we had to append new ones on the end. i suppose it's our own fault for not doing a better job of versioning this struct.
There was a problem hiding this comment.
I can't add a space here unless I turn off cargo fmt for the whole enum.
| BeenActivePlease, | ||
|
|
||
| /// Reply to `BeenActivePlease`. A region that has no record of being | ||
| /// active (including one created by an older downstairs) reports `false`. |
There was a problem hiding this comment.
I'm having trouble parsing including one created by an older downstairs, what do you mean here?
There was a problem hiding this comment.
The comment is,.. yeah. Let me fix this.
I was meaning a downstairs that may have been active before, but we had no means of recording that would report false. I can word that better.
2 participants
Add new message types for v14.
This just adds the message types into the enum. We don't use them yet.
Half of these comments will get updated as the rest of the work makes its way in.