Repository navigation
Conversation
Add DownstairsBuilder::set_max_message_version so tests can run a downstairs that only supports older message versions. The capped list is stored in DownstairsFlags and used when answering HereIAm. Log this manually set downstairs' message versions at startup instead of CRUCIBLE_MESSAGE_VERSION. Add matching plumbing to the downstairs unit test helpers and to TestDownstairs and TestDownstairsSet in the integration tests, which keep the cap across reboots. Going forward we can use this ability to build more complicated tests as the v14 work continues.
leftwo
added this pull request to stack #2045
October 16, 2026 19:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add DownstairsBuilder::set_max_message_version so tests can run a downstairs
that only supports older message versions. The capped list is stored in DownstairsFlags
and used when answering HereIAm.
Log this manually set downstairs' message versions at startup instead of
CRUCIBLE_MESSAGE_VERSION.
Add matching plumbing to the downstairs unit test helpers and to TestDownstairs and
TestDownstairsSet in the integration tests, which keep the cap across reboots.
Going forward we can use this ability to build more complicated tests as the v14 work
continues.