Skip to content

fix LPM extraction for composite keys - #272

Merged
nicolaskagami merged 2 commits into
mainfrom
nsk/fix-lpm-extraction
Aug 26, 2026
Merged

fix LPM extraction for composite keys#272
nicolaskagami merged 2 commits into
mainfrom
nsk/fix-lpm-extraction

Conversation

@nicolaskagami

@nicolaskagami nicolaskagami commented Aug 21, 2026

Copy link
Copy Markdown
Contributor
  • LPM extraction now checks the size of the type instead of the size of the key, which was only correct if the key wasn't composite.
  • It now correctly considers the "length" byte when advancing the offset.
  • A test was added to exercise those two scenarios with a composite (lpm, exact) key.

@rcgoodfellow rcgoodfellow left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. Has this been tested in voxel, a4x2 or omicron-local?

Comment thread test/src/vrf_router.rs Outdated
@nicolaskagami

Copy link
Copy Markdown
Contributor Author

Mostly LGTM. Has this been tested in voxel, a4x2 or omicron-local?

This was a required change for my voxel runs for the 662 poc, though they were run in a heavily altered system. I'll do a clean run with just this and the other p4 fixes.

@nicolaskagami

Copy link
Copy Markdown
Contributor Author

Mostly LGTM. Has this been tested in voxel, a4x2 or omicron-local?

Successfully ran voxel (rss, commtest) with this and the other two P4 changes.

@nicolaskagami
nicolaskagami merged commit 2ede7ca into main Aug 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants