fix range key offset and add vlan trunk test - #274
Merged
Conversation
rcgoodfellow
approved these changes
Aug 22, 2026
rcgoodfellow
left a comment
rcgoodfellow
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Have you run this through voxel with sidecar-lite?
Contributor
Author
Successfully ran voxel (rss, commtest) with this and the other two P4 changes. |
nicolaskagami
changed the base branch from
nsk/fix-bitvec-to-biguint-non-aligned
to
main
August 26, 2026 17:36
nicolaskagami
force-pushed
the
nsk/fix-range-composite-key
branch
from
August 26, 2026 17:53
b6c3562 to
0f721dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lens into account (startandendof offset).(range, exact)composite key.