algorithms: add support for SkEd25519, SkEcdsaSha2NistP256 - #8
Merged
Conversation
|
I've tested it with |
Contributor
Author
|
Friendly ping, anything that can be done to help this along? |
mvo5
added a commit
to mvo5/varlink-http-bridge
that referenced
this pull request
Jun 2, 2026
This commit moves the sshauth crate to https://github.com/mvo5/sshauth/tree/add-support-for-SkEd25519 until oxidecomputer/sshauth#8 is merged. With that we get support for the SkEd25519, SkEcdsaSha2NistP256 algorithms that are used by e.g. nitro keys.
mvo5
added a commit
to mvo5/varlink-http-bridge
that referenced
this pull request
Jul 10, 2026
This commit moves the sshauth crate to https://github.com/mvo5/sshauth/tree/add-support-for-SkEd25519 until oxidecomputer/sshauth#8 is merged. With that we get support for the SkEd25519, SkEcdsaSha2NistP256 algorithms that are used by e.g. nitro keys.
keszybz
pushed a commit
to mvo5/varlink-http-bridge
that referenced
this pull request
Jul 10, 2026
This commit moves the sshauth crate to https://github.com/mvo5/sshauth/tree/add-support-for-SkEd25519 until oxidecomputer/sshauth#8 is merged. With that we get support for the SkEd25519, SkEcdsaSha2NistP256 algorithms that are used by e.g. nitro keys.
mvo5
added a commit
to mvo5/varlink-http-bridge
that referenced
this pull request
Jul 10, 2026
This commit moves the sshauth crate to https://github.com/mvo5/sshauth/tree/add-support-for-SkEd25519 until oxidecomputer/sshauth#8 is merged. With that we get support for the SkEd25519, SkEcdsaSha2NistP256 algorithms that are used by e.g. nitro keys.
mvo5
added a commit
to mvo5/varlink-http-bridge
that referenced
this pull request
Jul 30, 2026
This commit moves the sshauth crate to https://github.com/mvo5/sshauth/tree/add-support-for-SkEd25519 until oxidecomputer/sshauth#8 is merged. With that we get support for the SkEd25519, SkEcdsaSha2NistP256 algorithms that are used by e.g. nitro keys.
jclulow
requested changes
Aug 31, 2026
jclulow
left a comment
jclulow
left a comment
Collaborator
There was a problem hiding this comment.
With my apologies for our delay in getting to this: it looks basically good, just want to trim out a few pieces and then we can get it integrated.
Thanks!
| bail!("unsupported key algorithm"); | ||
| bail!( | ||
| "unsupported key algorithm {}", | ||
| privkey.algorithm() |
Collaborator
There was a problem hiding this comment.
Suggested change
| privkey.algorithm() | |
| privkey.algorithm(), |
| Algorithm::Ecdsa { curve: EcdsaCurve::NistP256 } | ||
| | Algorithm::Ed25519 => (), | ||
| Algorithm::SkEd25519 | Algorithm::SkEcdsaSha2NistP256 => { | ||
| // this should never happen but lets be prepared |
Collaborator
There was a problem hiding this comment.
I think this is fine without the comment.
Suggested change
| // this should never happen but lets be prepared |
Comment on lines
+303
to
+310
| Algorithm::SkEd25519 | Algorithm::SkEcdsaSha2NistP256 => { | ||
| // this should never happen but lets be prepared | ||
| bail!( | ||
| "key algorithm {} requires a hardware token \ | ||
| and cannot sign directly; use an SSH agent", | ||
| privkey.algorithm(), | ||
| ); | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| Algorithm::SkEd25519 | Algorithm::SkEcdsaSha2NistP256 => { | |
| // this should never happen but lets be prepared | |
| bail!( | |
| "key algorithm {} requires a hardware token \ | |
| and cannot sign directly; use an SSH agent", | |
| privkey.algorithm(), | |
| ); | |
| } |
I don't think we need a special case here. The comment below about unreachability applies also for this case; i.e., the constrained builder prevents us from getting here.
jclulow
changed the title
mvo5
force-pushed
the
add-support-for-SkEd25519
branch
from
August 31, 2026 07:50
afd9b4e to
0246b53
Compare
Small commit to add support for the SkEd25519 algorithm that is used by e.g. nitro key.
This mirrors the previous commit and adds SkEcdsaSha2NistP256.
jclulow
force-pushed
the
add-support-for-SkEd25519
branch
from
August 31, 2026 12:26
0246b53 to
61b2f60
Compare
Collaborator
|
Thanks for the changes! |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[build on top of https://github.com//pull/7 as there are conflicts otherwise]
Small commit to add support for the SkEd25519, SkEcdsaSha2NistP256 algorithms that
are used by e.g. nitro keys.
Note that because this is a hardware key trying to use the privkey for it will error. I added the explicit arms for symmetry mostly, we could also just let them fall-through but I felt its slightly nicer being explicit. Happy to change that of course.