feat: implement merge source for compaction#413
Conversation
dab7993 to
e0dfb13
Compare
| type ( | ||
| Document = util.Pair[seq.ID, []byte] | ||
| DocBlockLocation = util.Pair[[]byte, uint64] | ||
| TokenPosting = util.Pair[[]byte, []uint32] |
There was a problem hiding this comment.
I have a strange feeling that we start to use two terms for same thing (lid and posting). I'd stick to a single term (which is a lid since we don't have much choise). At the same time docs/comments might mention that lids are postings.
Besides, a single posting == a single lid. So, util.Pair[[]byte, []uint32] is techically a posting list. But I'd suggest to stick to lids and rename to TokenLids
There was a problem hiding this comment.
Yeah, what I really meant here is TokenToPostingList, but for brevity I've dropped with part with To because this is Pair. Will rename it.
7689790 to
353316d
Compare
d3e1c9e to
0f1955e
Compare
5cbff00 to
fe8b2e8
Compare
aa2aecf to
50256a3
Compare
326908f to
dfa67ba
Compare
50256a3 to
b017111
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
==========================================
- Coverage 70.67% 70.27% -0.41%
==========================================
Files 226 229 +3
Lines 17611 18009 +398
==========================================
+ Hits 12447 12655 +208
- Misses 4238 4418 +180
- Partials 926 936 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
Description
Yet another pull request of series #336.
This one introduces all buildings blocks required for compaction of fractions.
If you have used LLM/AI assistance please provide model name and full prompt: