Skip to content

Avoid crashing on Go package URLs without a version #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codewithfourtix wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −3
Open

Avoid crashing on Go package URLs without a version #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b17eaa0
Avoid crashing on Go package URLs without a version
codewithfourtix Sep 5, 2026
c07be49
Address review feedback on validation and fallback coverage
codewithfourtix Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/packageurl/contrib/purl2url.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ def build_golang_download_url(purl):
name = purl_data.name
version = purl_data.version

if not name:
if not name or not version:
return
Comment thread
codewithfourtix marked this conversation as resolved.

# TODO: https://github.com/package-url/packageurl-python/issues/197
Expand All @@ -481,8 +481,7 @@ def build_golang_download_url(purl):
if not eversion.startswith("v"):
eversion = "v" + eversion

if name and version:
return f"https://proxy.golang.org/{ename}/@v/{eversion}.zip"
return f"https://proxy.golang.org/{ename}/@v/{eversion}.zip"


@download_router.route("pkg:pub/.*")
Expand Down
16 changes: 16 additions & 0 deletions tests/contrib/test_purl2url.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,3 +194,19 @@ def test_purl2url_get_repo_url_with_invalid_purls():
with pytest.raises(Exception) as e_info:
purl2url.get_repo_url(purl)
assert "Invalid PURL" == e_info


@pytest.mark.parametrize(
"purl",
[
"pkg:golang/google.golang.org/genproto#googleapis/api/annotations",
"pkg:golang/github.com/gorilla/context",
],
)
def test_golang_download_without_version(purl):
assert purl2url.get_download_url(purl) is None


def test_golang_download_without_version_uses_download_qualifier():
purl = "pkg:golang/github.com/gorilla/context?download_url=https://example.com/context.zip"
assert purl2url.get_download_url(purl) == "https://example.com/context.zip"