test-vectors feature replaced by runtime Domain::without_blinding - #93
Merged
Conversation
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit context: https://github.com/paritytech/srlabs_findings/issues/710
Replaces the
test-vectorscargo feature with a runtimeDomain::without_blindingmethod.The feature was a footgun due to cargo feature unification: features are additive and resolved once per build graph, so a downstream crate enabling test-vectors (e.g. to generate its own test vectors) would silently disable column blinding for every other dependent of
w3f-plonk-commonin the same build. Proofs would still verify, so nothing fails visibly, but they become deterministic and lose the zero-knowledge property, potentially leaking witness data in production.Blinding is now a per-instance runtime property.
Domain::without_blinding()disables it explicitly for that domain only, while preserving the layout (zk_rows, capacity) so the resulting deterministic proofs remain valid for verifiers using the regular blinding-enabled configuration. Intended for reproducible test vector generation.A regression test checks that columns are reproducible without blinding and randomized with it, with an unchanged domain layout.