nodes: improve modular cabinet constraints and finishes

[sudhir9297]

What does this PR do?

• Improves modular cabinet sizing with metric and US dimension profiles, standard widths, reveal presets, planning validation, and configurable top-cabinet or trim ceiling finishes.
• Reworks constrained run reflow so wider appliance presets consume available wall slack or resize eligible neighboring base cabinets while preserving two-wall extents.
• Keeps L-shaped corner runs governed by the original straight run's perpendicular-wall constraints, resynchronizes derived corner geometry after width changes, and rejects changes only when real donor capacity is insufficient.
• Adds focused coverage for straight, nested, chained, one-wall, two-wall, and two-ended L-run scenarios, plus cabinet finish and sizing behavior.

How to test

1. Run bun dev, open the editor, and create a straight modular base-cabinet run with perpendicular walls constraining both ends.
2. Add an L Left or L Right return at either end, then change a center or end module to a wider refrigerator preset. Confirm the original straight run keeps its wall-bounded extent, eligible base cabinets absorb the width change, and the L return stays inside the walls.
3. Switch the refrigerator back to a narrower preset. Confirm donated widths are restored and the L footprint remains anchored.
4. Remove one of the original run's perpendicular end walls and repeat the width changes. Confirm available wall slack is consumed first and the run moves only toward the open side without treating the derived L-leg wall as a source-run constraint.
5. Repeat with L returns on both ends and with a nested L-leg selected. Confirm constraints still come from the original straight run and valid refrigerator changes do not report “No space in this run.”
6. In the cabinet panels, verify standard dimensions, module widths, reveal gaps, planning warnings, and Top / Ceiling controls. Apply Top Cabinet and Trim / Soffit finishes and use Fill to ceiling.
7. Run bun test packages/nodes/src/cabinet, bun run check-types, bun run check, and bun run build.

Screenshots / screen recording

To be added — this is a visual and interactive cabinet-layout change.

Checklist

• I've tested this locally with bun dev
• My code follows the existing code style (run bun check to verify)
• I've updated relevant documentation (if applicable)
• This PR targets the main branch

---

Note

Medium Risk
Touches core cabinet layout reflow and schema defaults, so existing scenes and corner/L runs could resize differently; behavior is heavily tested but still user-visible geometry logic.

Overview
Adds research notes on modular kitchen sizing and ceiling-gap treatment, and implements the first slice of that model in Pascal cabinets.

Product model & defaults: Cabinet modules gain topFinish (none / top-cabinet / trim) with independent height and depth, rendered as stacked storage or a solid soffit and included in bounds. Shared metric 600 mm family defaults (CABINET_METRIC_DEFAULTS) replace the old 0.5 m depth baseline; dimension profiles, standard widths, and reveal gap presets feed the side panel. Refrigerator presets/stacks no longer add a drawer filler above the appliance—the carcass height follows the fridge column.

Layout & editing: Run reflow when applying wider presets or widths is reworked around perpendicular wall constraints (slack, growth detection, eligible donors). L-shaped corner runs keep constraints on the source straight run; derived legs are not mistaken for end walls. Failed reflow surfaces a clear “no space” notice instead of silently shrinking neighbors. Tall/wall modules get a height resize handle; front-style changes propagate to nested wall/top modules.

UI & checks: Module/run panels add Top / Ceiling (including fill-to-ceiling via cabinetCeilingGap), planning warnings/errors from validateCabinetRun, and run-level reveal sync. Corner fillers can use top finishes without preset conversion.

Extensive new tests cover reflow (straight, L, nested, two-wall), top-finish geometry, and sizing helpers.

^{Reviewed by Cursor Bugbot for commit 85476a4. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 85476a4. Configure here.}

[cursor]

Fill to ceiling overshoots

Medium Severity

cabinetCeilingGap always returns at least 0.05, even when the module already reaches or exceeds the ceiling. Fill to ceiling then sets topFinishHeight to that floor, so the top finish can poke through the ceiling instead of becoming a zero or near-zero closure.

Additional Locations (1)

• packages/nodes/src/cabinet/panel.tsx#L671-L680

 

^{Reviewed by Cursor Bugbot for commit 85476a4. Configure here.}

[cursor]

Height handle under finish

Low Severity

The new module height handle is placed with cabinetTotalHeight, which excludes topFinishHeight, while local bounds now include the top finish. With Top Cabinet or Trim active, the Y handle sits inside the finish volume instead of above the full composition.

Additional Locations (1)

• packages/nodes/src/cabinet/definition.ts#L503-L509

 

^{Reviewed by Cursor Bugbot for commit 85476a4. Configure here.}

[cursor]

Wall top finish unchecked

Low Severity

Planning checks run validateCabinetRun only on the parent run’s direct modules. Nested wall cabinets—the modules that commonly use Top / Ceiling—are omitted, and selecting a wall child clears parentRun, so top-cabinet-too-short never surfaces for them.

Additional Locations (1)

• packages/nodes/src/cabinet/validation.ts#L98-L108

 

^{Reviewed by Cursor Bugbot for commit 85476a4. Configure here.}