Repository navigation
Sync upstream 2026-10-02 - #13
Merged
Merged
Conversation
…athOfBuildingCommunity#2543) getGrantedSkillLevel falls back to level 1 when no level at or below the item's level qualifies. The 0.5.5 export defines some granted skills only at higher levels: Pinnacle of Power, granted by Adonia's Ego, has only level 20. levels[1] is then nil and CalcSetup errors while setting the gem's requirements, so any build with the wand fails to calculate. Fall back to the lowest level the skill defines instead.
…ommunity#2547) * Add support for Geofri's Sanctuary * Sunken armour conversion
Wrap gsub calls in parentheses to prevent the substitution count from being passed as the second argument to utf8.reverse.
…hOfBuildingCommunity#2542) ItemClass:BuildModListForSlotNum appends every JewelFunc it finds to self.jewelData.funcList but never clears it, as the `or { }` only creates the table when it is missing. jewelData is reset in BuildModList, which runs when the item is parsed, while the append also runs by way of GetActiveModListForSlotNum, which rebuilds the slot mod lists during calculation whenever the bonded rune state differs from the cached one. Every such rebuild leaves another copy of the jewel's radius functions behind. CalcSetup then creates one radiusJewelList entry per function, and refreshJewelStatCache appends each entry's modifiers into the same per-socket cached list, so a duplicated function applies the jewel's "Passive Skills in Radius also grant" stats one extra time to every node in radius. Building the passive tree power report runs a full calculation pass per node, which multiplies those stats several times over, and the inflated values then survive until the item is reparsed. Rebuild the list from the modifiers found in the current pass instead of appending to whatever was left over. This also stops a jewel from keeping functions it no longer grants after a variant change.
…ildingCommunity#2545) * Avoid incorrect Doedre's Undoing setup resulting in inf dps * Fix handling when used with ailments --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
…unity#2521) * Fix gem level behaviour of support granted skills * Add a test * Fix main gem lookup When having multiple skills with support effects it could use the wrong main skill as a level reference --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
…uildingCommunity#2528) * Add Gem Quality breakdown * Change quality tooltip to be more like in-game * Add missing + --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
…y#2544) * Add variants by runeforged/mastered variants by default for DB items * Fix variant selector spacing and add tests * Fix issues with legacy base variants --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
…ty#2523) * Fix DDS sheets assuming edge-to-edge images * Remove files that aren't included in current export * Fix tree background * Fix crash on old tree for background texture Removes the background texture as it was causing a crash on old trees and also doesn't really need to exist as it looks nicer as a smooth colour --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Show red text for unsupported rune mods * Fix multiline rune modifier tooltip colours * Handle bonded lines better --------- Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Add support for Raven-Touched * Add support for Jiquani and Kurgal's gaze conversion * Carved Majesty * Quipolatl's Thesis Armour Chaos Damage * Katla's Gloom Bonded ailment effect * Idol of the Pharisee command skill mana cost * Ulaman's Gaze Accuracy per helmet evasion * Idol of Maxarius and Rune of Claws (I don't actually know what sort of fissure skill has a cooldown, but surely it works) * Legacy of Tyranny's Grip * Legacy of Wings of Caelyn Bonded * Amanamu's Gaze Boots per spirit * Emergent Vigour Boots * Emergent Instinct Helmet * Carved Tenacity Helmet * Regen modcache and add orb limit * Fix raven touched and knockback Removing raven touched from an item wasn't removing the anointable state The knockback mod had the wrong parsing and would crash PoB --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
* Add FFI ZLib library * Fix trader for Forbidden Rites * Fix tests * Remove gzip exact string test due to docker version differences * Add license * Revert addition of zlib library * Improve error handling and disable tests broken by zlib approach change * Fix pasted trade searches Accept ordinary searches again and report malformed stat groups without crashing. Keep the weight bounds from pasted URLs, including searches with negative weights or no minimum. Only add weight bounds to purchase links for weighted searches. Keep the regression tests for these cases and remove duplicate cases and the commented-out compression tests. --------- Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com>
…0-02 # Conflicts: # src/Classes/TradeQuery.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges upstream/dev (16 non-merge commits) into dev.
Conflict:
src/Classes/TradeQuery.lua— upstream PathOfBuildingCommunity#2502 (trader Gzip link support) restructured Find best into arequestQueryHandlerand JSON-encodes the query before POST. Resolved per P2: upstream's structure kept, fork's "register search, return URL only"PerformSearchcall re-applied on top (it takes the encoded body as-is).Verification: verify-port.sh — 15 fork-patched files before/after, no dropped or unsignatured lines, no mode changes, no P5 sibling dirs. luajit syntax check passed. busted not on PATH locally; relying on CI. SimpleGraphic was already up to date.