Repository navigation
fix(adjoint): keep saves that land on a step end - #789
Open
Cherith1222 wants to merge 2 commits into
Open
Cherith1222 wants to merge 2 commits into
Cherith1222 wants to merge 2 commits into
Conversation
A recomputed step end can sit two ULPs below the forward value, so a sample that lands on that end is dropped and its cotangent is zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A recursive checkpoint adjoint drops the derivative of a sample that lands on a step end. Recomputing that step rounds the end two ULPs early, so the save is skipped and the sample adds nothing to the gradient.
What changed
Scope
Blast Radius
This touches solves that record output on step ends and then differentiate them. Forward samples were already correct. The wider test only pulls in a time that rounding had pushed just past the recomputed end.
Verification
test/test_adjoint.pywithout the slow test: 11 passed.test/test_saveat_solution.py: 26 passed.Fixes #788
Drafted with Cursor.