Skip to content

Bug - Tabs - Navigation tabs incompatible with React Router #12676

Closed

Description

@jon-nfc

Describe the problem
This is an issue with

  • Patternfly 5

  • Patternfly 6

  • other

Please give a clear and concise description of the problem. Which components are affected?

How do you reproduce the problem?

When defining tabs you can set them up to be part of navigation. Then when the tabs render, instead of a HTML button a html anchor is rendered instead as long as the tab was defined with the href prop.

There is no option to supply a different component to render inplace of the hardcoded HTML anchor.

So what?

Other components have acknowledged that for patternfly to work correctly with ReactRouter, you must pass through the Link component so that navigation occurs correctly. Without the ability to pass the object, a HTML anchor tag causes a full reload of the page, and for a SPA reloading all of the JS again is far from ideal.

Expected behavior
A clear and concise description of the expected behavior.

Any place where a HTML anchor is used, that you can pass a ReactRouter.Link

Is this issue blocking you? Yes
List the workaround if there is one.

No Workaround

Screenshots
If applicable, add screenshots to help explain the issue.

What is your environment?

  • OS: All
  • Browser All
  • Version All

What is your product and what release date are you targeting?

Any other information?


Jira Issue: PF-4726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions