Skip to content

fix(InProgressIcon): Replace InProgressIcon with RhUiInProgressIcon#12458

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-in-progress-icon-with-rh-ui-in-progress
Open

fix(InProgressIcon): Replace InProgressIcon with RhUiInProgressIcon#12458
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-in-progress-icon-with-rh-ui-in-progress

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 12, 2026

Copy link
Copy Markdown
Member

What:
This is one piece of #12400. Breaking it up by icon so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Style
    • Updated the in-progress status icon used across file upload and progress stepper components for consistent visual styling.
  • Documentation
    • Aligned example documentation to reflect the updated in-progress icon.
  • Tests
    • Updated component tests/snapshots to match the new in-progress icon rendering.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5c3dc0a9-5330-4743-ab8d-65da8ae3d30b

📥 Commits

Reviewing files that changed from the base of the PR and between 382588c and 94cf51a.

⛔ Files ignored due to path filters (1)
  • packages/react-core/src/components/MultipleFileUpload/__tests__/__snapshots__/MultipleFileUploadStatus.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (4)
  • packages/react-core/src/components/MultipleFileUpload/MultipleFileUploadStatus.tsx
  • packages/react-core/src/components/MultipleFileUpload/__tests__/MultipleFileUploadStatus.test.tsx
  • packages/react-core/src/components/ProgressStepper/examples/ProgressStepper.md
  • packages/react-core/src/components/ProgressStepper/examples/ProgressStepperCustomIcons.tsx
✅ Files skipped from review due to trivial changes (1)
  • packages/react-core/src/components/ProgressStepper/examples/ProgressStepperCustomIcons.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/react-core/src/components/ProgressStepper/examples/ProgressStepper.md
  • packages/react-core/src/components/MultipleFileUpload/MultipleFileUploadStatus.tsx

Walkthrough

Replaces InProgressIcon with RhUiInProgressIcon in MultipleFileUploadStatus (component and test) and in ProgressStepper example/documentation.

Changes

In-Progress Icon Replacement

Layer / File(s) Summary
MultipleFileUploadStatus component and test
packages/react-core/src/components/MultipleFileUpload/MultipleFileUploadStatus.tsx, packages/react-core/src/components/MultipleFileUpload/__tests__/MultipleFileUploadStatus.test.tsx
Import swapped from InProgressIcon to RhUiInProgressIcon; the 'inProgress' render branch now returns <RhUiInProgressIcon /> and the test snapshot updated to match.
ProgressStepper examples and documentation
packages/react-core/src/components/ProgressStepper/examples/ProgressStepper.md, packages/react-core/src/components/ProgressStepper/examples/ProgressStepperCustomIcons.tsx
Example and docs import and render RhUiInProgressIcon instead of InProgressIcon for the in-progress step.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

Needs design review

Suggested reviewers

  • nicolethoen
  • thatblindgeye
  • kmcfaul
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly and accurately summarizes the main change: replacing InProgressIcon with RhUiInProgressIcon across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-in-progress-icon-with-rh-ui-in-progress branch from 382588c to 94cf51a Compare June 12, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants