Skip to content

docs(Page): Fix missing import in page demos - #12685

Merged
rebeccaalpert merged 3 commits into
patternfly:mainfrom
wise-king-sullyman:fix-page-demo-missing-import
Oct 21, 2026
Merged

rebeccaalpert merged 3 commits into
patternfly:mainfrom
wise-king-sullyman:fix-page-demo-missing-import

Conversation

@wise-king-sullyman

@wise-king-sullyman wise-king-sullyman commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes issue breaking page demos which is live on prod

Summary by CodeRabbit

  • Documentation
    • Updated the Page demo to include settings, help, branding, and avatar assets.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ddc965ac-482b-4837-8657-e54a7b98bf57
📥 Commits

Reviewing files that changed from the base of the PR and between 2e5ddbf and bb9d1c3.

📒 Files selected for processing: 1
  • packages/react-core/src/demos/Page.md

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2d15046a-6987-422c-9f25-ba0ad91931ec
📥 Commits

Reviewing files that changed from the base of the PR and between 568984c and 2e5ddbf.

📒 Files selected for processing: 1
  • packages/react-core/src/demos/Page.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Walkthrough

The Page demo now imports settings and question-mark icons.

Changes

Page demo

Layer / File(s) Summary
Add icon imports
packages/react-core/src/demos/Page.md
The Page demo imports RhUiSettingsFillIcon, RhUiQuestionMarkCircleIcon, and RhUiQuestionMarkCircleFillIcon.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: rebeccaalpert

Merge Risk: ⚪ Minimal · up to 2e5dd

No merge-blocking issues were identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the change: it fixes a missing import in the Page demos. This matches the pull request objective and file changes.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; just waiting for tests/CI to pass.

@rebeccaalpert
rebeccaalpert merged commit 3c2093d into patternfly:main Oct 21, 2026
11 checks passed
@patternfly-build

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-code-editor@6.7.1-prerelease.0
  • @patternfly/react-core@6.7.1-prerelease.0
  • @patternfly/react-docs@7.7.1-prerelease.0
  • @patternfly/react-drag-drop@6.7.1-prerelease.0
  • @patternfly/react-integration@6.5.0-prerelease.25
  • demo-app-ts@6.5.0-prerelease.138
  • @patternfly/react-table@6.7.1-prerelease.0
  • @patternfly/react-templates@6.7.1-prerelease.0

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants