Fixes to get to dokieli compatiblity#34
Open
ylebre wants to merge 5 commits into
Open
Conversation
Packagist no longer support re-tagging a release. Since the v0.14.0 release has been removed, v0.14.0 has been re-tagged as v0.14.1.
Potherca
reviewed
Jun 23, 2026
| if (preg_match("/^http(s)?:/", $clientId)) { | ||
| $clientData = self::getRemoteRegistration($clientId); | ||
| if (!isset($clientData['origin']) && isset($clientData['client_uri'])) { | ||
| $clientData['origin'] = preg_replace("/\/$/", "", $clientData['client_uri']); |
Member
There was a problem hiding this comment.
I'd prefer rtrim to using a RegExp:
$clientData['origin'] = rtrim($clientData['client_uri'], '/');
Potherca
approved these changes
Jun 23, 2026
Potherca
left a comment
Potherca
left a comment
Member
There was a problem hiding this comment.
Nothing functionally wrong.
One nitpick, feel free to resolve or ignore at will.
I've added a commit to bump the solid-auth version, as Packagist no longer allows re-tagging releases. See https://packagist.org/about/version-immutability.
(Release v0.14.0 and v0.14.1 are both tags on the same commit.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch contains the fixes go make things work with Dokie.li