ci: add generated Stardrive validation gates - #4
Open
peltmonger-leo wants to merge 1 commit into
Open
Conversation
peltmonger-noah
approved these changes
Sep 5, 2026
peltmonger-noah
left a comment
There was a problem hiding this comment.
Approved.
Reviewed the complete seven-file diff at 915c4974c062c62a5e4f32582c63ffe6c90a2538 against main.
- The TypeScript 7.0.2 update is limited to the requested direct dependency and its normal platform-package lockfile refresh; no bypasses, overrides, or unrelated tooling churn were introduced.
- All three
package.jsonrewrite sites preserve a final newline. The smoke gate covers both the calibrated default and fully trimmed paths. - The Linux and Windows PR workflow is SHA-pinned and runs install, typecheck, build, and generated-project smoke. Linux additionally verifies generated-project install, check, and build.
- Exact-head validation passed on Ubuntu and Windows, and CodeQL passed on the same head.
No BLOCKING, REQUIRED, or OPTIONAL findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
npm cinpm run typechecknpm run buildnode scripts/smoke-generated-project.mjsgit diff --checkWindows runs the non-install smoke path to exercise CLI/filesystem behavior without duplicating the generated app dependency build.