Skip to content

Fix build on older RHEL and CentOS release - #2690

Merged
kurik merged 1 commit into
performancecopilot:mainfrom
kurik:atop2
Aug 11, 2026
Merged

Fix build on older RHEL and CentOS release#2690
kurik merged 1 commit into
performancecopilot:mainfrom
kurik:atop2

Conversation

@kurik

@kurik kurik commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Older RHEL and CentOS releases do not support Recommends directive.

Older RHEL and CentOS releases do not support 'Recommends' directive.
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Updated RPM packaging to conditionally recommend pcp-atop only on supported platforms and RHEL versions.
    • Corrected the packaged PCP release version to 7.2.1-1.
  • Chores
    • Updated RPM changelog information for the 7.2.1 release.

Walkthrough

The RPM specifications now recommend pcp-atop only outside RHEL or on RHEL versions newer than 7. The Red Hat specification version changes to 7.2.1-1, with an updated changelog entry.

Changes

RPM packaging

Layer / File(s) Summary
Conditional recommendation and release metadata
build/rpm/pcp.spec.in, build/rpm/redhat.spec
The specifications conditionally recommend pcp-atop. redhat.spec updates the package version to 7.2.1-1 and replaces the previous changelog entry.

Possibly related PRs

Suggested reviewers: natoscott, kmcdonell

Poem

A rabbit checks the RPM nest,
And keeps the atop rule expressed.
For RHEL seven, paths stay clear,
Newer builds may recommend it here.
Seven-two-one hops into view.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description accurately identifies the unsupported Recommends directive on older RHEL and CentOS releases.
Title check ✅ Passed The title clearly summarizes the main change: fixing builds on older RHEL and CentOS releases.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@build/rpm/redhat.spec`:
- Around line 3552-3553: Update the changelog entry for version 7.2.1-1 in the
RPM spec to use the actual package release date, replacing the future-dated
August 14, 2026 value while preserving the existing release notes.
- Around line 3552-3553: Update the RPM changelog in build/rpm/redhat.spec by
preserving the existing 7.2.0-2 release entry and appending the new 7.2.1-1
entry above it, maintaining the prior release history and changelog ordering.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 3153d389-b1c2-46a1-8725-3a262ce259b1

📥 Commits

Reviewing files that changed from the base of the PR and between 5b519c5 and 3c03932.

📒 Files selected for processing (2)
  • build/rpm/pcp.spec.in
  • build/rpm/redhat.spec

Comment thread build/rpm/redhat.spec
@kurik
kurik marked this pull request as ready for review August 11, 2026 05:54
@kurik
kurik merged commit 4101ea4 into performancecopilot:main Aug 11, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant