Repository navigation
ui: put templates first on the templates page and mark unbuilt ones - #1255
Merged
Merged
Conversation
The templates page opened on the rolling warm-pool policy table, usually empty, had no page title, and listed the templates themselves third. A template with no published release (never built, or every build failed) showed "latest" in its Hash column, the same as a built template's tag. The Network column's tags and Edit link overflowed into the Base Snap toggle. The page now has a title with the refresh action, and lists templates, then releases, node availability and warm-pool policies. A template with no release shows "not built" with an explanation. The Hash and Network columns are wide enough for their contents.
|
Thanks for opening this pull request! A SPACE maintainer will take a look. CONTRIBUTING.md explains how we review outside contributions. |
The Hash column called a template "not built" when its content_hash was null. That field comes from builder inventory, not from releases, so a published template that no builder node reports showed "not built", and the rule was not what the previous commit's message described. A present template now shows "no release" only when the releases have loaded and none names it. The tooltip says it may never have been built, every build may have failed, or its releases were unpublished. A published template without a build hash shows a dash, with a tooltip saying it is published. Correction to the previous commit's message: it is not layout only. Its Hash column change is a behavior change, and its "not built" rule tested the build hash, not whether a release exists.
zibi-pplx
previously approved these changes
Nov 1, 2026
zibi-pplx
dismissed
their stale review
November 1, 2026 22:30
Withdrawing this approval for now. Any feedback above still stands.
Collaborator
Review — no findingsNo findings. Verified against What I checked:
What I didn't check: the visual layout (I didn't render the page), and the column widths at other viewport sizes. |
the-gigi-pplx
approved these changes
Nov 2, 2026
the-gigi-pplx
left a comment
Collaborator
There was a problem hiding this comment.
Approved. No findings; details in the review comment above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The templates page now opens on the templates, and says when a template has no published release.
Before this change:
latestin its Hash column, the same text a built template's tag shows, whether or not it had a published release.Changes:
content_hash, which comes from builder inventory. Once the releases have loaded, a present template that no release names shows no release, with the tooltip "No release has been published for this template: it may never have been built, every build may have failed, or its releases were unpublished." A published template that no builder node reports a build hash for shows—, with the tooltip "Published; no builder node reports a build hash for it."Build history and build failures are still not visible. The admin API has no route that lists a template's builds, only one that reads a build by job ID.
Stack
Independent of the other open console PRs. It edits
ui/src/app/dashboard/templates/page.tsx, which #1250 also trims; whichever merges later may need a small rebase.Validation
npm ci,npm test(50 pass) andnpm run buildinui/.—with the "Published" tooltip, and that nothing is called unreleased while the releases are still loading.main(production build) and on this branch (the Kindspace-uiimage).main.Visual confirmation
Severity and risk
Severity: low.
Risk: low. Besides the layout, the Hash column's empty state changes meaning: it reports whether a release exists, read from the releases list. The first commit's message says the change is layout only and that "not built" means no release; the follow-up commit's message corrects both, and the squash keeps every commit message. Roll back by reverting the commits.
AI assistance: Claude Code wrote the code and this description, and ran the validation; a maintainer reviews it.