Skip to content

api: page and filter the admin sandbox list, count spaced versions, and share one sandbox ID parser #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ac-pplx merged 5 commits into from
Nov 3, 2026
Merged

api: page and filter the admin sandbox list, count spaced versions, and share one sandbox ID parser #1321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0973b19
api: page and filter the admin sandbox list, and accept every sandbox…
ac-pplx Nov 2, 2026
aef3be8
api: count what the admin list shows, and page it through the controller
ac-pplx Nov 2, 2026
77c635b
api: drop the admin list's node filters and add no Direct table read
ac-pplx Nov 2, 2026
eb9be9f
api: parse the admin list's lifecycle filter without the placement store
ac-pplx Nov 3, 2026
411c536
api: keep IDs and bodies out of admin list test messages
ac-pplx Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion architecture-baseline.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
"crates/libs/api/src/public_operations.rs" = 1787
"crates/libs/api/src/public_sandbox_operations.rs" = 1023
"crates/libs/api/src/routes/admin/node_maintenance.rs" = 1783
"crates/libs/api/src/routes/admin/sandboxes.rs" = 1011
"crates/libs/api/src/routes/admin/templates.rs" = 2262
"crates/libs/api/src/routes/e2b/lifecycle.rs" = 1236
"crates/libs/api/src/routes/public/sandboxes.rs" = 1245
Expand Down
2 changes: 2 additions & 0 deletions crates/libs/api/src/controllers/sandbox/list_page.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ pub(crate) const MAX_SANDBOX_LIST_PAGE_BYTES: i64 = 8 * 1024 * 1024;
/// of native JSON, up to about 1.1 KB with the longest template reference.
pub(crate) const SANDBOX_LIST_ROW_OVERHEAD_BYTES: i64 = 2 * 1024;

pub(crate) mod admin;

/// The placeholders of the bound values [`page_rows_cte`] reads, such as
/// `"$11"`, and the columns it sizes. The caller binds the cursor's
/// `created_at` and `id` (both NULL for the first page), the most rows to
Expand Down
Loading
Loading