Skip to content

DO NOT MERGE: show the console CI job failing - #1650

Closed
ac-pplx wants to merge 1 commit into
ac/ci-console-checksfrom
ac/ci-console-checks-demo
Closed

ac-pplx wants to merge 1 commit into
ac/ci-console-checksfrom
ac/ci-console-checks-demo

Conversation

@ac-pplx

@ac-pplx ac-pplx commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Do not merge. This draft adds one commit on top of ac/ci-console-checks that breaks ui/'s type check (a number passed to URLSearchParams in ui/src/lib/sandbox-list.ts), so CI shows the new Admin console job failing at tsc while the unit tests pass.
It will be closed unmerged once that run has shown the failure.

@coderabbitai

coderabbitai Bot commented Nov 6, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

@github-actions github-actions Bot added the triage:pending Waiting for a maintainer to triage label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! A SPACE maintainer will take a look.

CONTRIBUTING.md explains how we review outside contributions.

@ac-pplx

ac-pplx commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

Closing unmerged, as planned. CI showed what this draft was for: the new Admin console job failed at the type check (TS2345 in src/lib/sandbox-list.ts) while the console's unit tests passed, and that failure made space-pull-ci fail. The job passes on #1649 without this commit.

@ac-pplx ac-pplx closed this Nov 6, 2026
@ac-pplx
ac-pplx deleted the ac/ci-console-checks-demo branch November 6, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage:pending Waiting for a maintainer to triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant