Repository navigation
sbx-mgr: make encrypted suspend capture resumable - #1761
Draft
NancyKwongPerplexity wants to merge 1 commit into
Draft
NancyKwongPerplexity wants to merge 1 commit into
NancyKwongPerplexity wants to merge 1 commit into
Conversation
Port of #837 (by @mabdelraouf-pplx) onto current main. Adds the node-manager CreateEncryptedSuspendSnapshot RPC, which captures an encrypted runtime and stages its ciphertext as one operation keyed by the capture's local artifact id. Each step records its outcome in the staging directory, so a retry after a lost reply (e.g. the 120 s gRPC request timeout firing while the detached capture keeps running) resumes staging a confirmed capture instead of rolling the sandbox back to paused and later quarantining it. Rebase notes: paths moved from crates/libs to crates/l40_api, metrics moved to crate::metrics, the Cloud Hypervisor capture now threads the recorded boot source, and test row states use SandboxStatus. Co-authored-by: Perplexity <noreply@perplexity.ai>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #837 (by @mabdelraouf-pplx) onto current
main. This is the durable fix for the encrypted-suspend quarantine race, and the companion to #1760.Change (from #837)
CreateEncryptedSuspendSnapshotRPC. It captures an encrypted runtime and stages its ciphertext as one operation, keyed by the capture's local artifact id.paused, and it never captures over a capture whose outcome is unknown.Rebase notes
crates/libs/*→crates/l40_api/*;pplx_space_metrics::{byok,snapshot}→crate::metrics::*.snapshot_boot_source), because main added that parameter.btrfs_send_encode_falls_back_to_full. Droppedfailed_encrypted_capture_may_release_volume, as sbx-mgr: make encrypted suspend capture resumable #837 did.SandboxStatus. Cleanup-required expectations areSandboxStatus::owned(Teardown::Suspending, CleanupState::Required).Testing
cargo check -p pplx-space-node-mgr -p pplx-space-sbx-mgr --testsis clean.encrypttests pass (36).Supersedes #837.
Created with Perplexity