Repository navigation
fix: use opaque cache keys in error logs - #40
Merged
Merged
Conversation
ravi-pplx
marked this pull request as ready for review
November 9, 2026 22:59
ravi-pplx
added a commit
that referenced
this pull request
Nov 9, 2026
Cache keys can contain complete upstream URLs, including signed query parameters. Logging the raw key when a cache write or cached response fails can expose those values at ERROR level. Use the existing SHA-256 cache object key in both error records instead. This preserves correlation without changing upstream requests, cache identity, error severity, or response streaming. Regression tests exercise a storage-write failure and a failed cached-response write. They require an observable error and the corresponding opaque cache key, reject synthetic signed-query values in the logs, and preserve full delivery on a cache-write failure. <sub>Created with [Perplexity](https://www.perplexity.ai/computer/tasks/5f970909-348b-4848-b2d7-6c1a3912784a)</sub>
ravi-pplx
added a commit
that referenced
this pull request
Nov 12, 2026
Cache keys can contain complete upstream URLs, including signed query parameters. Logging the raw key when a cache write or cached response fails can expose those values at ERROR level. Use the existing SHA-256 cache object key in both error records instead. This preserves correlation without changing upstream requests, cache identity, error severity, or response streaming. Regression tests exercise a storage-write failure and a failed cached-response write. They require an observable error and the corresponding opaque cache key, reject synthetic signed-query values in the logs, and preserve full delivery on a cache-write failure. <sub>Created with [Perplexity](https://www.perplexity.ai/computer/tasks/5f970909-348b-4848-b2d7-6c1a3912784a)</sub>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache keys can contain complete upstream URLs, including signed query parameters. Logging the raw key when a cache write or cached response fails can expose those values at ERROR level.
Use the existing SHA-256 cache object key in both error records instead. This preserves correlation without changing upstream requests, cache identity, error severity, or response streaming.
Regression tests exercise a storage-write failure and a failed cached-response write. They require an observable error and the corresponding opaque cache key, reject synthetic signed-query values in the logs, and preserve full delivery on a cache-write failure.
Created with Perplexity