Repository navigation
fix(spool): treat client hangup after full body as complete - #41
Merged
Merged
Conversation
A coalesced reader that has already sent the whole declared Content-Length waits for the fill to commit before returning. If the client hangs up in that window, the reader reported context.Canceled and the handler logged a served response as a failure. Return success when the declared body was fully sent; earlier disconnects still return the context error.
ravi-pplx
marked this pull request as ready for review
November 13, 2026 04:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A coalesced reader that has sent the full declared
Content-Lengthstill waits for the fill to commit before returning. Clients that hang up as soon as they have the body (the common case) cancel that wait, so the handler logsFailed to serve shared response ... context canceledat error level for a response that was delivered in full.This returns success in that case. A client that disconnects before the full body is sent still gets the context error, and fill failures seen while the client is connected are unchanged.