Repository navigation
site: show the latest publish time in the pkg footer - #39
Conversation
Footer gains " · Site updated <time class="site-updated">" taken from the newest package Published epoch (never the render clock), so pages change only on a publish and re-renders of an unchanged tree stay byte-identical. Refs pfBlockerNG/pfBlockerNG#3485 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013XM3rHnWFhaMd1A767cq36
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 47 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The generated pages show the newest available package publication time, or omit it when none exists. No material merge risk was established. Pre-merge checks |
|
- N1: footer date text and datetime attribute now identical to the main site
("11 Oct 2026, 19:34 UTC", datetime=...+00:00).
- N2: the pkg page script rewrites the footer with the main site's handler
(toLocaleString with timeZoneName short); the table-time rewrite skips it.
- N3: comment that the footer epoch is the newest package build/source epoch
(the Published column), which can precede the actual publish.
- Test: the re-render test now moves time.time between renders, so a
clock-derived footer would fail it.
Refs pfBlockerNG/pfBlockerNG#3485
Review audit — legs 1+2: contract and correctness
Evidence:
Nitpicks and how they were handled:
|
Review audit — legs 3+4: test honesty and over-engineering
Evidence:
|
Review audit — Grok (independent second reviewer)
CI 🤖 Generated with Claude Code |
Adds
· Site updated <time class="site-updated" datetime=...>YYYY-MM-DD HH:MM UTC</time>to the pkg footer (all pages), taken from the newest package Published epoch (manifestcreated, else build-recordsource_date_epoch) thatcollect_packagesalready reads. No render clock, so pages change only on a publish.Tests (test-first, RED before / GREEN after):
test_footer_site_updated_is_the_newest_publish_time(fixture with two catalogues, newest wins, every page) andtest_rerender_of_an_unchanged_tree_is_byte_identical. Both failed before the change.Render proof against
git archive origin/main docs: only footers differ; install.sh, catalogues and all non-HTML files byte-identical; stripping the new span makes every HTML page byte-identical to the origin/main render; a second render is byte-identical.Full suite on clean
git archive HEADexport (umask 022): pytest 792 passed;LC_ALL=C shellspec --shell dash99 examples, 0 failures.Refs pfBlockerNG/pfBlockerNG#3485
🤖 Generated with Claude Code
https://claude.ai/code/session_013XM3rHnWFhaMd1A767cq36
Summary by CodeRabbit