fix: compare only observed baseline sections - #101
Open
DivyamTalwar wants to merge 1 commit into
Open
DivyamTalwar wants to merge 1 commit into
DivyamTalwar wants to merge 1 commit into
Conversation
Missing or unavailable observations previously became false connection drops, standby losses and new-query or archiving events. Check section provenance while retaining observed zero and positive legacy measurements. Regression coverage includes real SQLite history and input immutability. Verification: affected packages pass with the race detector. No collector SQL, dependency or JSON schema changes. Revert this commit to restore the prior behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Closes #100.
Unavailable or missing collector sections could be interpreted as measured zeros or empty sets, creating false connection drops, standby losses, new-query entries and archiver events. Require observable section provenance at both ends while preserving genuinely measured empty results and positive evidence in legacy snapshots. A retained positive connection gauge remains usable when only rates are unavailable.
Verification
Verified commit:
9811ed1faab48344389ba5c5a31687df272e887d.bash scripts/gate.sh, andgo test -race ./...pass.Scope, risk and rollback
No schema, SQL, dependency or migration changes. This suppresses comparisons unsupported by observations, not genuine measurements. It is distinct from #64 (cross-reset comparability), #69 (standby multiplicity) and #87 (stored scalar extraction), though the diff edits may need reconciliation as those land. No live PostgreSQL failure is claimed. Revert the commit to restore the former comparison rules.
Checklist
scripts/gate.shpasses on committed HEAD; full race suite passes.