fix: fail incomplete database inspections - #99
Open
DivyamTalwar wants to merge 1 commit into
Open
DivyamTalwar wants to merge 1 commit into
DivyamTalwar wants to merge 1 commit into
Conversation
A successful subset of database inspections previously hid failures in other databases. Preserve the useful report but give execution failure precedence over findings. The subprocess regression exercises actual CLI parsing, fanout, JSON rendering and exit codes. Verification: affected packages pass with the race detector. No collector SQL, dependency or JSON schema changes. Revert this commit to restore the prior behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Closes #98.
When at least one database succeeded, runInspectAll calculated its exit status only from successful contexts, ignoring a failed database. Preserve the successful subset of the report, but let execution failure (exit 3) take precedence over finding thresholds. The all-failed and complete-success cases retain their existing behavior.
Verification
Verified commit:
945e9a67b93b56a90cdc81ec59cf9cf84366dcbb.bash scripts/gate.sh, andgo test -race ./...pass.Scope, risk and rollback
No collector SQL, model fields, dependencies or migrations change. PR #38 overlaps the fanout file but its partial-failure handling is conditional on all-instances; this corrects plain all-databases independently. No live connection-failure simulation is claimed. Revert this commit to restore the former exit precedence.
Checklist
scripts/gate.shpasses on committed HEAD; full race suite passes.