T42 modernize refactor app#43
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
… reset Drop the Codeception rollback machinery from AbstractIntegrationTestCase: no rollback option, no begin/rollback, no savedRecords tracking, no delete loop through the models under test. tearDown truncates the co_ tables at the database level and setUp clears the Redis data cache, so every test starts from an empty database and cache regardless of order. Fix testLoginKnownUserGetUnknownUser to ask for the id after the one it creates - a fixed /users/1 only worked while ids ran into the thousands.
Add resources/infection.json5 with method-scoped mutator ignores, the test-mutation composer script, the extension-installer allow-plugin and a psr-4 map so infection can reflect the source. The infection dependency is not committed - it pulls thecodingmachine/safe dev-master, which deprecation warns on newer php; install it on demand to run. Harden the tests so mutants die: Response send hash and meta, ClearcacheTask exact output with redis, UsersRepository lookups, the model logger call and BaseTransformer field selection. Covered MSI 92%.
This comment has been minimized.
This comment has been minimized.
This was referenced Jul 16, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked dockerfiles to use phalcon v5/v6
Update composer
Mirror vokuro setup with folder reorganization, configs, etc.
Use talon
Refactoring for coupling/optimizations
Phpstan at 8
Coverage > 82%
Run infection