Preserve physics group config with existing children#7322
Open
Farley-Chen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the provided config when creating Arcade Physics groups with existing children.
Both dynamic and static physics groups replaced the provided
configwhenchildrenwas not a plain object or an array of plain objects. This caused options passed as the second argument to be ignored for calls like:This change keeps the existing config object and appends the internal callbacks instead of replacing it.
Manual test
Created an Arcade Physics Group from an existing GameObject array with
{ collideWorldBounds: true }.Before this change:
After this change: