Skip to content

Fix BaseTween callback types - #7358

Open
bagel786 wants to merge 1 commit into
phaserjs:masterfrom
bagel786:fix/base-tween-callback-types
Open

Fix BaseTween callback types#7358
bagel786 wants to merge 1 commit into
phaserjs:masterfrom
bagel786:fix/base-tween-callback-types

Conversation

@bagel786

Copy link
Copy Markdown

This PR

  • Fixes a bug

Model BaseTween callback slots as the required nullable handler objects used at runtime, including their callback parameters. Add a TypeScript generation regression for every callback key.

Tests:

  • npm run ts
  • ESLint 8 on the changed JSDoc sources

Fixes #7353

@bagel786
bagel786 marked this pull request as ready for review August 29, 2026 17:10
Copilot AI lite review requested due to automatic review settings August 29, 2026 17:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BaseTween#callbacks type is inconsistent with runtime behaviour

2 participants