Skip to content

Types: Narrow Tween configuration inputs - #7359

Open
bagel786 wants to merge 1 commit into
phaserjs:masterfrom
bagel786:fix/tween-manager-config-types
Open

Types: Narrow Tween configuration inputs#7359
bagel786 wants to merge 1 commit into
phaserjs:masterfrom
bagel786:fix/tween-manager-config-types

Conversation

@bagel786

Copy link
Copy Markdown

This PR

  • Fixes a bug

Replace broad object fallbacks with the explicit Tween config and instance types supported at runtime. Keep custom properties and Tween Chain target inheritance while rejecting invalid primitive and arbitrary-object inputs.

Tests:

  • npm run tsgen
  • npm run test-ts
  • npx vitest run tests/tweens/builders/TweenBuilder.test.js tests/tweens/builders/TweenChainBuilder.test.js

Fixes #7260

@bagel786
bagel786 marked this pull request as ready for review August 29, 2026 17:10
Copilot AI lite review requested due to automatic review settings August 29, 2026 17:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TweenManager.create and similar functions take overly permissive object config types

2 participants