Skip to content

Keep opaque inline content out of bracket matching - #320

Merged
dereuromark merged 2 commits into
masterfrom
fix/opaque-link-destination-brackets
Oct 18, 2026
Merged

dereuromark merged 2 commits into
masterfrom
fix/opaque-link-destination-brackets

Conversation

@dereuromark

@dereuromark dereuromark commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Keep link destinations, span attributes, and code spans opaque while matching an outer bracketed run. A ] inside any of those constructs must not close an earlier [.

The new cases cover both literal outer text and an outer link that closes after the nested construct.

Verification

  • Added eight parser regressions and compared the representative outputs with djot.js.
  • PHPUnit: 4,603 tests, 31,183 assertions passed.
  • PHPCS passed for both changed files.

@dereuromark dereuromark added bug Something isn't working skip-changelog labels Oct 18, 2026
@codecov

codecov Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.15%. Comparing base (87ad03f) to head (c97c8e9).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #320   +/-   ##
=========================================
  Coverage     93.14%   93.15%           
- Complexity     4776     4785    +9     
=========================================
  Files           118      118           
  Lines         12733    12748   +15     
=========================================
+ Hits          11860    11875   +15     
  Misses          873      873           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dereuromark dereuromark changed the title Fix bracket scanning across link destinations Keep opaque inline content out of bracket matching Oct 18, 2026
@dereuromark
dereuromark merged commit 5942f63 into master Oct 18, 2026
6 checks passed
@dereuromark
dereuromark deleted the fix/opaque-link-destination-brackets branch October 18, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant