Skip to content

Preserve invalid multiline comments as text - #322

Merged
dereuromark merged 5 commits into
masterfrom
fix/rejected-multiline-comments
Oct 18, 2026
Merged

dereuromark merged 5 commits into
masterfrom
fix/rejected-multiline-comments

Conversation

@dereuromark

@dereuromark dereuromark commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Keep malformed multiline comments visible when a continuation is blank or lacks the required indentation. Parse the resulting paragraph normally so inline markup and block boundaries still work. Unclosed comments keep the existing strict-mode warning.

Verification

  • vendor/bin/phpunit (4,615 tests)
  • composer stan and composer cs-check

Matches the comment cases in djot.js #165 and djot.js #166.

@dereuromark dereuromark added bug Something isn't working skip-changelog labels Oct 18, 2026
@codecov

codecov Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.47826% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.17%. Comparing base (5cd45f2) to head (316d3e9).

Files with missing lines Patch % Lines
src/Parser/BlockParser.php 93.47% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #322      +/-   ##
============================================
+ Coverage     93.16%   93.17%   +0.01%     
- Complexity     4787     4805      +18     
============================================
  Files           118      118              
  Lines         12753    12795      +42     
============================================
+ Hits          11881    11922      +41     
- Misses          872      873       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dereuromark
dereuromark force-pushed the fix/rejected-multiline-comments branch from 91b346b to 133770b Compare October 18, 2026 19:37
@dereuromark
dereuromark merged commit f1274f3 into master Oct 18, 2026
6 checks passed
@dereuromark
dereuromark deleted the fix/rejected-multiline-comments branch October 18, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant