Repository navigation
Preserve invalid multiline comments as text - #322
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #322 +/- ##
============================================
+ Coverage 93.16% 93.17% +0.01%
- Complexity 4787 4805 +18
============================================
Files 118 118
Lines 12753 12795 +42
============================================
+ Hits 11881 11922 +41
- Misses 872 873 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dereuromark
force-pushed
the
fix/rejected-multiline-comments
branch
from
October 18, 2026 19:37
91b346b to
133770b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep malformed multiline comments visible when a continuation is blank or lacks the required indentation. Parse the resulting paragraph normally so inline markup and block boundaries still work. Unclosed comments keep the existing strict-mode warning.
Verification
vendor/bin/phpunit(4,615 tests)composer stanandcomposer cs-checkMatches the comment cases in djot.js #165 and djot.js #166.