Skip to content

Attach word attributes across smart apostrophes - #323

Merged
dereuromark merged 1 commit into
masterfrom
fix/inline-attribute-apostrophes
Oct 18, 2026
Merged

dereuromark merged 1 commit into
masterfrom
fix/inline-attribute-apostrophes

Conversation

@dereuromark

Copy link
Copy Markdown
Contributor

Summary

Attach a word attribute to the full contraction when smart quote parsing puts its apostrophe in a separate text node. A quote at the edge of a word remains a boundary.

Verification

  • vendor/bin/phpunit (4,607 tests)
  • vendor/bin/phpcs on changed PHP files

Addresses the don't{.x} case in djot.js #166.

@dereuromark dereuromark added bug Something isn't working skip-changelog labels Oct 18, 2026
@codecov

codecov Bot commented Oct 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.19%. Comparing base (5cd45f2) to head (3b0b0f1).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #323      +/-   ##
============================================
+ Coverage     93.16%   93.19%   +0.02%     
- Complexity     4787     4795       +8     
============================================
  Files           118      118              
  Lines         12753    12764      +11     
============================================
+ Hits          11881    11895      +14     
+ Misses          872      869       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dereuromark
dereuromark merged commit 14afedd into master Oct 18, 2026
6 checks passed
@dereuromark
dereuromark deleted the fix/inline-attribute-apostrophes branch October 18, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant