Repository navigation
Fix verbatim padding at either backtick boundary - #325
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #325 +/- ##
=========================================
Coverage 93.20% 93.21%
Complexity 4815 4815
=========================================
Files 118 118
Lines 12812 12821 +9
=========================================
+ Hits 11942 11951 +9
Misses 870 870 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Djot removes one padding space independently at either end of verbatim text when the content touches a backtick. The PHP parser required spaces at both ends, which added spaces to six code spans in the authored-document benchmark. This change follows the Djot rule and matches djot.js on all three documents.
The HTML-to-Djot converter now pads only the needed end. A code value with a significant space next to a boundary backtick cannot be written as one Djot verbatim span, so that rare case uses an escaped
<code>raw-inline form. It retainsid,class, andtitleand drops event attributes.Checks